fix(parser): handle all token types in process substitution reconstruction#1073
Merged
fix(parser): handle all token types in process substitution reconstruction#1073
Conversation
…ction Add explicit handlers for DoubleLeftBracket, DoubleRightBracket, DoubleLeftParen, DoubleRightParen, DoubleSemicolon, SemiAmp, DoubleSemiAmp, Assignment, RedirectBoth, Clobber, DupInput, HereDoc, HereDocStrip, RedirectFdAppend, DupFd, DupFdIn, DupFdClose, RedirectFdIn, ProcessSubIn, ProcessSubOut, and Error tokens in the process substitution token reconstruction loop. Previously these fell through to the catch-all branch and were silently dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[ ]],(( )), and other compound constructs to fail[[ ]]conditionals, while+break with conditionals, and(( ))arithmetic inside process substitutionsTest plan
cargo test -p bashkit --lib -- test_process_sub— all 7 tests pass (4 existing + 3 new)cargo fmt --check— clean